Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

checker: add missing check for duplicated items on in expr #22308

Merged
merged 6 commits into from
Sep 26, 2024

Conversation

felipensp
Copy link
Member

Fix #22305

vlib/v/checker/infix.v Outdated Show resolved Hide resolved
@esquerbatua
Copy link
Contributor

Great job!

felipensp and others added 2 commits September 25, 2024 09:03
Co-authored-by: Jose Mendoza  <56417208+StunxFS@users.noreply.github.com>
@felipensp felipensp marked this pull request as ready for review September 26, 2024 00:11
vlib/v/checker/infix.v Outdated Show resolved Hide resolved
Copy link
Member

@spytheman spytheman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work.

@spytheman spytheman merged commit 31e71e9 into vlang:master Sep 26, 2024
78 checks passed
@felipensp felipensp deleted the fix_checker_dup_items branch September 26, 2024 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

missing checker notice/warning for a known duplicate value in a if x in [val1, val1, val2] {
6 participants